Repository navigation
fix(keybindings): print Lua-compatible combos - #7660
ketpatil77 wants to merge 5 commits into
Conversation
Signed-off-by: ketpatil77 <243740572+ketpatil77@users.noreply.github.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
prioritize_entries recognised the secondary browser chord as "SUPER SHIFT ... B", the format --print used before this branch. With every modifier now joined by " + ", the pattern stopped matching, so SUPER + SHIFT + B took the primary Browser slot and sorted ahead of SUPER + SHIFT + RETURN. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The records cache is keyed on a version string, the active keymap and hyprctl binds, none of which change when the chord formatting does. Without a bump, an upgraded install keeps serving "SUPER SHIFT + B" from its cache to both --print and the menu until its bindings happen to change. Co-Authored-By: Codex Medium <noreply@openai.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed and verified on a disposable Omarchy worker (Hyprland 0.56.2). The problem in #7627 is real and this fixes it: I pushed three commits to the branch:
Tests on the worker: The second opinion was Codex Medium, over two rounds. It found the stale cache, which the first commit above fixes, and its second round on the final head found nothing open. It also raised two points I've left for the maintainer rather than changed here. First, the menu's filter is a literal substring match, so typing Nothing is needed from you. This waits on the maintainer. |
[Low impact] This PR appears safe to merge. SummaryFormats multi-modifier shortcuts with
Reviews (1) · Last reviewed commit: "Merge current quattro and refresh format..." · Reviewed by Greptile |
|
Re-checked at b6822a0, the merge of current Verified again on a disposable Omarchy worker (Hyprland 0.56.2). Tests on the worker: The second opinion was Codex Medium. It reviewed this head and found nothing open. It agreed with my reading of the cache key, the Browser patterns and the menu's exact-match selection, though its independence isn't guaranteed. The points in my earlier comment are unchanged and still for the maintainer: the menu filter no longer matches Nothing is needed from you. This waits on the maintainer. |
What changed
Format every modifier separator in
keybindings --printwith+.Printed bindings such as
SUPER + SHIFT + Scan now be copied directly intohl.unbind(...)oro.bind(...).Closes #7627
Testing
parse_binding_recordswithSUPER SHIFT,SandSHIFT ALT,Dgit diff --check